Jacob Walls

Results 483 comments of Jacob Walls

Not related to the cache. (I should do a little refactor to avoid the KeyError from a cache miss showing up in the tracebacks like this.) EDIT: done, see pylint-dev/astroid#2205...

pylint-django should catch and deal with AstroidImportError when calling ast_from_module_name. Should we also guard against it safe_infer()? I think it's better to guard against errors you reasonably expect, so probably...

Sorry, I'm not the reporter! But from this: ``` astroid.exceptions.AstroidImportError: Failed to import module projects.models with error: No module named projects.models. ``` it seems like the change in the rc...

We can track this separately. The RefactoringChecker needs to call `utils.is_terminating_func()` somewhere.

Thanks for the report. This is a good case for extending astroid's constraint framework. I'm showing this is fixed with: ```diff diff --git a/astroid/constraint.py b/astroid/constraint.py index 08bb80e3..57b41701 100644 --- a/astroid/constraint.py...

That patch is probably a little too wide, but I hope it's on the right direction.

Hi @tanaydin. If you're caught up responding to Sarah's feedback, can you please uncheck "Patch needs improvement" on the ticket so it goes back in the review queue? Thanks!

(Small typo in the first commit message: move -> model)

Sorry to be a pest, but there are two more typos: Movel -> Model as well as Adusted -> Adjusted (d20f90d)

Hey Natalia, thanks for the first look. > I also saw there is a fixtures class attribute in TransactionTestCase that would seem to do (from its comment) what you require,...