Jacob Walls

Results 476 comments of Jacob Walls

Hi :wave: @ulgens > I see that .client is assigned to cls instead of self, but I couldn't understand why that change would cause this weird behaviour. I think that's...

Hi @john-parton, thanks for this. In your opinion is this feature request ready for evaluation by the community? If so, would you like to get the ball rolling by opening...

> Could be false negatives, will look into this. The primer tests still suffer from a fluctuating baseline, so you'll see unrelated messages moving in and out from time to...

FYI @badsketch, thanks to some ace detective work by @akamat10, the primer is more stable now, so if you merge main you should see a more informative primer diff.

@badsketch Sorry I didn't catch this before merge, but would you add a short breaking changes news fragment to indicate that we no longer emit fixme when contained in a...

A test for `unittest_lint.py`. Doesn't seem to be fixed on PyCQA/astroid@d45b33c72b33d719224efeb88d7b8e4f493717c7. ```python def test_lint_namespace_package(initialized_linter: PyLinter) -> None: linter = initialized_linter with tempdir(): create_files(["namespace/__init__.py", "namespace/submodule.py"]) create_files(["other/namespace/namespace.py"]) with open(Path("namespace/submodule.py"), "w", encoding="utf-8") as...

See #3984 for an even simpler test case. I'm optimistic but not certain that a fix would handle both cases.

Ah, I just noticed that the Refs # .... commit only contains a comment. Instead, I was imagining that that that preparatory commit would consist of the entire test that...

Hey @matusvalo just mentioning it might be worth it to get a new benchmark on memory usage after https://github.com/PyCQA/astroid/pull/1521. If you use `MANAGER.clear_cache()` between runs, is the memory usage now...

What if you explicitly call garbage collection?