Isitha Subasinghe

Results 130 comments of Isitha Subasinghe
trafficstars

@terrytangyuan it shouldn't change anything for users, it will introduce an additional config map where mutex related data is stored.

Hmm I thought it was https://github.com/argoproj/argo-workflows/pull/12736 as well due to a git blame I came upon. I suppose the quickest way to find out what the first offending commit is...

@Mic92 could you please review/merge this?

@sarabala1979 we really need some data store, configmaps can be used but obviously have the 1MB limit imposed by etcd. Even dealing with the configmap limit is still a better...

Also pinging @terrytangyuan and @juliev0 so that they can have a read.

Actually correct me if I am wrong about Postgres| MySql not being mandatory, if it is mandatory, makes more sense to just use that.

@sarabala1979 this gives an example of why mutex release fails: https://github.com/argoproj/argo-workflows/blob/49865b1783b481ba7600441999559821d1a03a18/docs/proposals/mutex-improvements.md I do not think the fix is that easy, the information available on acquire is different to the information...

> We should stay away from any external dependencies like DB unless really necessary and leverage any cloud-native solutions whenever possible. @terrytangyuan I generally agree on this, but I think...

@juliev0 Yeah I believe this is correct, we generate information over and over to avoid dealing with configmap limitations (1MB).