Isitha Subasinghe
Isitha Subasinghe
@jingkkkkai DCO isn't passing and the test suite isn't passing, maybe try commit an empty commit.
Thanks for letting me know @wucke13, in that case I will create some PRs there for anything missing there.
resurrected the PR here: https://github.com/argoproj/argo-workflows/pull/14450
@terrytangyuan I am on holidays atm, I can get a review done tomorrow, a bit busy tonight.
I had another look at this, I was wrong, this is certainly still an issue. The names we generate are too long. This is somewhat worrying to me. We do...
@terrytangyuan that is a fair concern, I think it maybe possible to generate shorter aliased pod names that way.
Note: This uses the deprecated `govaluate` library. This is very intentional and done to keep the logic similiar to the other When fields. Initially I implemented this using purely `expr`...
You can also get the weekday it seems in expr-lang: https://expr-lang.org/docs/language-definition#date-functions So you can probably use @agilgur5 's solution above along with this to get the behaviour @tooptoop4 Probably a...
Perhaps another feature could be stored functions to help with more complex expressions, that way you could reference these stored functions instead of having to write your expressions inline.