Isitha Subasinghe

Results 131 comments of Isitha Subasinghe

After looking at the expr-lang/expr code, I am surprised how this ever worked actually. expr-lang has two phases, a compile phase and a run phase. The eval function first compiles...

Created an issue: https://github.com/expr-lang/expr/issues/520, let's see how they respond.

Thanks @antonmedv, appreciate your quick response

This has now been addressed in expr-lang, waiting for a new release, if urgent we can probably just use master.

@juliev0 Yeah I did do some work on pod deletion I think, I can have a look now.

@terrytangyuan you need to merge this one first: https://github.com/argoproj/argo-workflows/pull/12514

> @isubasinghe are you comfortable being the Assignee for this one, so you may be able to merge it once you officially have access to? Yup happy to merge when...

Please note `DISABLE_MAX_RECURSION=true` is not a safe solution for this problem. I ran into a stack overflow when I came across this, I also made some progress on RCA-ing this....

@sarabala1979 the issue isn't created yet, but this PR addressed this comment by Alex where we decided to store the podName in the Node status: https://github.com/argoproj/argo-workflows/issues/10267#issuecomment-1630308619

> I only took a quick glance at this, but doesn't this need to modify [the UI code as well](https://github.com/argoproj/argo-workflows/blob/3652241a42be8e1cc699719f97ff7af2c7ca86c5/ui/src/app/shared/pod-name.ts)? I thought I replied to this, must have just not...