Isitha Subasinghe

Results 130 comments of Isitha Subasinghe
trafficstars

@MasonM This is on my TODO to test out and approve. Not really related to this PR: It would be nice if the benchmark results were a displayed on PRs...

@jingkkkkai Given that we only support the last two minor versions (3.6.x and 3.5.y), could you please confirm if this bug exists on 3.5 or 3.6? Thanks

@cyyangnb can you confirm which version you are on? Is this HEAD of main?

Okay thanks so much for examining this issue in depth, do you want to open a PR for your fix?

@cyyangnb I will review your PR, apoligies on the delay on getting back to you.

@luyang93 I've only now had a quick look into CSI drivers, I had no idea this existed. I believe theoretically that should also be possible.

@nicdard I see you have pushed some commits regarding this fix, I just wanted to check how that was going?

@nicdard do you want to open the PR anyway ? We can the discuss it. I would like to see the diff, if you want you can leave th e...

Thanks @MasonM, I do plan to tackle this hook issue eventually, I just want to think about the hook thing a bit first before I change the interface, mainly I...

@nicdard can you please rebase this?