Gregory Popovitch

Results 101 comments of Gregory Popovitch

Thanks Ed. I had updated manually the KeySanity.cmake last week, but forgot all about it :-), so indeed the change is needed!

Can I submit a libc++ PR via github?

Hi @Jonahowns , thank you for using phmap. You mention that you use vectors of 2048 elements each. If the size is constant, then you can use `std::array` instead of...

No problem. Is the code open source? I'd like to have a look if possible. > The flat_hash_map values contain the index of the data which matches the particular hash...

Oh, man, I'm sorry, I meant to look into this and forgot all about it. Glad you found a good solution to your problem! Don't hesitate to ask again if...

Thanks for letting me know, @HolyBlackCat . It was a contribution and I don't use it myself, but I'll have a look when I have some time. It probably isn't...

@HolyBlackCat I fixed the issues you mentioned. I believe it is working fine for the `flat` versions. The `node` versions still need some work.

Thanks for the kind words! > have the ability to "steal" the backing array from the flat-maps (after compacting them into a "normal" array first of course.) Should not be...

Hum, there is the issue of the allocator used for allocating the array inside the flat_hash_set. If you steal the buffer, then you also need to use the same allocator...

OK, I did the first part, added `gtl::vector`.