validator-keys-tool icon indicating copy to clipboard operation
validator-keys-tool copied to clipboard

Published 20 hours ago • verified publisher icon ripple

Improve Visual Studio build check for newer versions

Open ximinez opened this issue 3 years ago • 3 comments

This is basically the same change that was included in https://github.com/ripple/rippled/pull/4150

Building with the Visual Studio 19 or 22 cmake generators fails because "Win64" is not included in the name. That's because the naming convention was changed between 17 and 19 to not include the architecture, and the default was changed to 64-bit, so the check can be a lot looser.

ximinez avatar May 23 '22 17:05 ximinez

Is this file even used? When building the validator-keys-tool I had to update the one in .nih_c coming from the rippled download

greg7mdp avatar May 23 '22 17:05 greg7mdp

It is. Make sure that the rippled download has version 1.9.1, which has this same fix. Basically, this condition gets checked twice - once by validator-keys-tool, once by rippled. If you try to build develop using one of the VS generators ("Visual Studio 16 2019" or "Visual Studio 17 2022"), it will fail.

ximinez avatar May 23 '22 22:05 ximinez

Thanks Ed. I had updated manually the KeySanity.cmake last week, but forgot all about it :-), so indeed the change is needed!

greg7mdp avatar May 23 '22 22:05 greg7mdp

@ximinez is this still worth including? Should I merge it?

intelliot avatar Feb 23 '23 04:02 intelliot

is this still worth including? Should I merge it?

@intelliot I think it is, yes.

ximinez avatar Feb 23 '23 18:02 ximinez