Gregory Popovitch

Results 101 comments of Gregory Popovitch

Great, thanks @kleunen, let me look at that first!

Thanks. Please give me a couple days to look into it.

Hum, I'm not sure. I did try your example with a change in phmap but I got a very strange error. I need to look more into it. ![image](https://user-images.githubusercontent.com/1496907/117483525-d19f4100-af33-11eb-899c-638ca5d4f8d2.png)

> I think you should consistently use Alloctor::pointer and not convert to raw pointers. How can I do that since I allocate the hashmap array itself using the allocator and...

Hi @rob-p, Thanks for the kind words! This type `struct std::pair` is in fact safe to reallocate, even if the c++11 API std::is_trivially_copyable returns false. `sparsepp` doesn't require a c++11...

@rob-p yes indeed the moved-from object should be in a consistent state, so this is a bug. I'll look into it when I have some time. In the meanwhile maybe...

Hi @Shaheen47 , I added a conan recipe. Does this help?

> The only significant downside is that our only [VS documentation is for 17](https://github.com/ripple/rippled/blob/develop/Builds/VisualStudio2017/README.md) (AFAIK), so that'll have to be updated. otoh that doc is correct for 2019/2022 so it...

@RichardAH - I think the issue might be that you used curly braces for the std::string constructor. Can you try using parentheses? `std::string raddr((char*)(memory + read_ptr), read_len);` greg

> Still doesn't work for me. Can you please test yourself also? It's technically possible my specific build environment is responsible for the outcome I see Hum, I apologize, I'm...