Gregory Popovitch

Results 101 comments of Gregory Popovitch

OK, so I managed to sidestep the issue by building and installing the latest version of [protobuf](https://github.com/protocolbuffers/protobuf/releases) and doing a clean build (after deleting `.nih_c` and my build directory. I...

Worked for me on Windows 11, Visual Studio 2019

> Note that with my changes, the Windows and Linux action builds are succeeding. The MacOS one is still failing, but I am not sure how to fix it. https://github.com/ximinez/rippled/runs/7732011453?check_suite_focus=true...

Maybe we could check (on linux/macos) whether ntpd is running, and if it is, just use the system's time (assuming ntpd will do a better job than we could avoiding...

Yes @nbougalis you are 100% correct, thanks for clarifying, I have updated the PR description.

Thanks @nbougalis I merged the commits and updated the message.

@HowardHinnant @nbougalis @ximinez @mtrippled I think I would like to abandon this PR. Because of the effort that was made to release the `SHAMAPTreeNodes` outside the lock, I was under...

OK, fair enough and thanks @mtrippled and @ximinez , I'll make the requested changes.

They have to be powers of two if you want to be able to set and test the bits individually. For example if you define: ``` enum { A=1, B=2,...

You can use a sequence 1,2,3,4,5,... if all the conditions are exclusive from one another. But if they are flags that can be set independently, then it has to be...