Gregory Popovitch

Results 101 comments of Gregory Popovitch

> I've actually seen this conflict before (can't recall when). It doesn't occur on the compilers I use but I will change the name for you now. Thanks @RichardAH, this...

> I only build on linux, so I'm not sure 😬 Is this specific to the Hooks PR or does rippled in general cause this? The current version of rippled...

@scottschurr the following is Nik's branch with my my additional changes which should build https://github.com/greg7mdp/rippled/tree/slab_alloc

@mtrippled I also think it would make sense to create a new PR. I suggested it a few days back, but @nbougalis said he would take care of it, probably...

Thanks @scottschurr for trying the mac version. I did build my branch on all 3 platforms (linux, windows, mac). @nbougalis , we should either update that PR or start a...

> @scottschurr I'd love to have the word `wait` in the name somewhere - or something that implies that this function can sleep. or `yield()`?

Nice, thanks @chennakeshava1998 , but I don't think it is necessary to leave the old code commented out.

Nice! Looks very clean now. > Do I need to clean up the commits? (I can do a force push with a single commit) Yes, I think it would be...

I approved the PR, but I don't have write access to the repo, so it doesn't count.

I have this error as well. Happens both with and without a local protobuf install. Tried cleaning `.nih_c` and also setting `-Dlocal_protobuf=ON` but didn't help. After I built and installed...