K. S. Ernest (iFire) Lee
K. S. Ernest (iFire) Lee
Hooray! I will review as I can.
Can you rebase to master and apply the `pre-commit run -a` to format the code?
Test plan: 1. Go to Mac. 1. Build this Godot engine pull request. 2. Launch the Godot Engine headless. 3. See if any windows or icons show.
I'll take a look
Unmerging that pr seemed to have no effect. What made the fog work was precision=single.
We need to debate adding a new option, but that can review that in a separate pr. That means you can stack the two prs together into that pr.
I think this needs a rebase on master.
I can link to the algorithm for specular to metallic / roughness but I need a qualitative judgement like is it better looking.
I am ok with the ufbx material intepretation to be honest.
Are you ok with splitting this issue into the 6 mentioned earlier and closing? - ufbx bad spine: [FBX2glTF](https://github.com/godotengine/godot/assets/3875461/80b26533-3a75-410f-a42e-18d87f99b967), [ufbx](https://github.com/godotengine/godot/assets/3875461/951b68e7-8a37-4d11-a014-37d5557e7caf) - ufbx missing hair and shoes: [FBX2glTF](https://github.com/godotengine/godot/assets/3875461/753fa180-3273-4cbd-aab7-5772c9b55d96), [ufbx](https://github.com/godotengine/godot/assets/3875461/4c09f2ef-4a21-4d4a-a994-a6d6f1b6845d) - ufbx...