K. S. Ernest (iFire) Lee

Results 1455 comments of K. S. Ernest (iFire) Lee

I think this is right but can't code review for the next few days.

I’ curious since this is an optimization there should be profiles that show faster performance.

Anyways I would recommend getting a profile to confirm. Profiling can be unintuitive. This seems clearcut so it might be a good intro to setting up profiling for ourselves.

@Calinou made a benchmark server, we may be able to check total runtime on some of the benchmark tests to see improvement.

Is all the steps completed to close this? Do we need to cherry pick?

I approve of allowing saving the color pallete from a usability team perspective.

I'll put this on my list to review for the pipeline import.

1. Run the godot engine binary with `--doctool` to update the documentation 2. I'll try to give you guidance for the "json" property being set as the default value Here...

I was stuck, I suspect we need to use the resource importer system that takes json and gives a LottieTexture2D