K. S. Ernest (iFire) Lee comments

Results 1280 comments of


                                            K. S. Ernest (iFire) Lee

trafficstars

Quaternions: Handle 180 degree arcs in the shortest arc constructor better

Here are the concerns: - [x] Animation team reviewed - [x] We should fix this. The reason is that Quaternion's 180 degree slerp is valid and often used. - [...

Quaternions: Handle 180 degree arcs in the shortest arc constructor better

- [ ] Reduce code duplication in look_at and other places in Godot Engine - [ ] Check possible inconsistency with slerp and generated arc. - [ ] Non-animation team...

Generate arguments for virtual functions that take `float` as taking `float` (rather than `double`)

float means double in gdscript. I am not sure the exact way to resolve this.

svg: support the background-image:url in style

Try the one from https://github.com/lovell/sharp/issues/3557

svg: support the background-image:url in style

Expected: ![image](https://github.com/thorvg/thorvg/assets/32321/95103e87-49c4-4313-beb9-14896b8378e1) Result: ![image](https://github.com/thorvg/thorvg/assets/32321/e5984024-8863-4431-b199-9dfaeef5a6ed)

Importing Animpic Studio POLY_MegapolisCityPack fails

> There are still some errors thou. Can you go into detail what the errors are?

Update Groups 4.3 to 4.3-stable

Speech is not compiling in cicd.

Update Groups 4.3 to 4.3-stable

Done.

`vsk-3d-audio-variant-4.3` is failing on cicd

``` if env_resonance["platform"] == "windows": env_resonance.Append(CCFLAGS=['/wd2099']) ``` Will probably fix this.

`vsk-3d-audio-variant-4.3` is failing on cicd

As of https://github.com/V-Sekai/merge/commit/86276bf6cf7ba1ec613fb74509ed71b25a67c409 we don't build resonance audio.