Eric Pugh

Results 567 comments of Eric Pugh

Once you get your PR done for SOLR-16409, then maybe this PR can be closed in favour of the more general solution!

I've wondered if the whole `wt=ruby` is actually a feature of Solr worth supporting? I think it was a "good idea", but seriously, who uses it? How does it actually...

I just looked and https://github.com/rsolr/rsolr/blob/master/lib/rsolr/client.rb#L12 suggests Rsolr doesn't do `wt=ruby`, so I may see about deprecating that code in Solr 9! As far as the whole back compat, I think...

Is there anyway to have a performance (benchmark?) test that demonstrates the performance hit?

interesting! Honestly, I think my question really goes to the desire that we have as a community about having benchmarks in general, and doesn't have anything specific to this JIRA...

Maybe for an adjacent library, just having a fixed version that lives as someone's personal fork in Github would also be okay? Versus bringing in this code to the Solr...

@cpoerschke I am going through various issues that I had assigned to me, to catch up on where they are. Is there any reason not to merge this test? I...

Did a bit more work, and I think we should: - [x] Eliminate all the `MatcherAssert.assertThat` and just have `assertThat()` - [x] Eliminate all the `@Rule public ExpectedException` in favour...

So, I am rethinking this PR... I think I was falling into the trap of having too many different changes in one PR... So, I'm going to remove the task...