Eric Pugh

Results 567 comments of Eric Pugh

Let's give it another few days, and then, if I don't review/merge it, can you bug me? Say Thursday??? Thanks for this @danrosher

This looks like a nice clean up, do you want me to test out the code and see if I can fix the checks? Is there anything you found that...

Looks like we need a JIRA ;-)

Instead of adding more complexity, could we just configure the `unified` highlighter here and get rid of the others? I like the ida of identifying unused configurations, but maybe that...

@mkhludnev I spotted a double space, so removed it, then changed the wrapping.

Makes sense to me... I wonder if we need to have a conversation on dev mailing list related to when we merge this? I know @dsmiley is interested in seeing...

I would love to see these get merged, as keeping this patch up to date is going to get harder... Do we have consensus on merging it?

@sayandigital I'm going to click the workflow now. However, two things to ready this for committing: 1) Can you add a unit test that demonstrates the NPE? That would make...

The code for loading the `_multilingual` configset is rough, and probably can be refactored. However it all appears to work!

TestSchemaDesignerConfigSetHelper.testEnableDisableOptions is busted... TestSchemaAPI all works.....