solr icon indicating copy to clipboard operation
solr copied to clipboard

Published 20 hours ago • verified publisher icon apache

SOLR-10059: add SearchHandlerAppendsCloudTest

Open cpoerschke opened this issue 4 years ago • 1 comments

https://issues.apache.org/jira/browse/SOLR-10059

cpoerschke avatar Nov 20 '21 21:11 cpoerschke

@cpoerschke I am going through various issues that I had assigned to me, to catch up on where they are. Is there any reason not to merge this test? I ran it, and it passes... Is the idea that once SOLR-10059 is merged, you would change the test to confirm that the bug ISN'T present?

BTW, I love the scheme field names you picked ;-)

epugh avatar Aug 10 '22 11:08 epugh

... Is there any reason not to merge this test? ...

Thanks for the ping!

From (very vague) memory the test/code behaviour was non-deterministic and part-mysterious, though maybe the continue; with the // SOLR-10059: sometimes (but not always) filterQueriesList contains duplicates fully accounts for that. Let me go check.

cpoerschke avatar Aug 15 '22 16:08 cpoerschke

... maybe the continue; with the // SOLR-10059: sometimes (but not always) filterQueriesList contains duplicates fully accounts for that. ...

Looks like it does. Also just merged latestorigin/main into the PR branch.

cpoerschke avatar Aug 15 '22 17:08 cpoerschke

Awesome!

epugh avatar Aug 19 '22 14:08 epugh