solr icon indicating copy to clipboard operation
solr copied to clipboard

Published 20 hours ago • verified publisher icon apache

SOLR-16300: migrate assert to non deprecated version

Open epugh opened this issue 3 years ago • 10 comments

https://issues.apache.org/jira/browse/SOLR-16300

Description

intellij has flagged various deprecations in how we assert in our tests.

Solution

This PR has two approaches for migrating. One is to use the non deprecated class MatcherAssert, the other is to override the deprecated method from the org.junit.Assert class that our tests inherit from, and use the non deprecated class.

Tests

Ran gw test successfully.

epugh avatar Jul 19 '22 15:07 epugh

Did a bit more work, and I think we should:

  • [x] Eliminate all the MatcherAssert.assertThat and just have assertThat()
  • [x] Eliminate all the @Rule public ExpectedException in favour of assertThrows()
  • [x] Migrate containsString() method to CoreMatchers.containsString()
  • [x] Use assertThrows instead of the try, fail(), catch check. Look for boolean expectedException

epugh avatar Jul 20 '22 20:07 epugh

So, I am rethinking this PR... I think I was falling into the trap of having too many different changes in one PR... So, I'm going to remove the task "Double check all the files for other asserts that can be simplified.", as that is a LOT of changes. I will go through and clean up any MatcherAssert.assertThat that can be replaced with a assertThat if they extend the right Solr test base class....

epugh avatar Jul 26 '22 14:07 epugh

@cpoerschke I'd love a review, I think this is ready!

epugh avatar Jul 26 '22 14:07 epugh

See also https://github.com/apache/lucene/pull/1049 and LUCENE-10662

madrob avatar Jul 26 '22 17:07 madrob

19 / 26 files viewed

I wonder if we could/should also put the assert versions in question on the 'forbidden list' e.g. https://github.com/apache/solr/tree/main/gradle/validation/forbidden-apis or in some other way to avoid re-introduction of what is cleaned up here?

That is a great suggestion. I haven't touched that feature of our build system before.

epugh avatar Aug 24 '22 14:08 epugh

19 / 26 files viewed I wonder if we could/should also put the assert versions in question on the 'forbidden list' e.g. https://github.com/apache/solr/tree/main/gradle/validation/forbidden-apis or in some other way to avoid re-introduction of what is cleaned up here?

That is a great suggestion. I haven't touched that feature of our build system before.

You have 3 options:

  • add the whole class into the forbiddenapis file (works for MatcherAssert if we do not want to use it)
  • add a whole series of a single method name with all overloads (Class#method(**))
  • list all methods to be forbidden (can be quite many) with all overloads

I'd add a separate txt file with correct name. The Gradle build automatically loads some forbiddenapis files when a specific dependency is in classpath. So it can be names forbiddenapis-hamcrest.txt (just example, the file name semantics are described in forbiddenapis.gradle). This prevents us from applying forbiddenapis in modules where the forbidden JAR file is not on classpath.

uschindler avatar Aug 24 '22 16:08 uschindler

I gave it a stab of adding it to forbiddenapis, but didn't quite get it to work... There are some places that it's okay, like in the LTR module... May need a pairing session to grok this!

epugh avatar Aug 25 '22 12:08 epugh

We can delay this to a separate PR. I also need try and error for this, because @dweiss implemented that Gradle code which picks the signatures files from that folder.

uschindler avatar Aug 25 '22 16:08 uschindler

Thanks for approving the changes @uschindler! I'm waiting on @cpoerschke to finish her review, and the SolrJ-Zookeeper to get merged, and then I'll merge this one!

epugh avatar Aug 25 '22 19:08 epugh

I've fixed the merge conflict, so I'd like to merge this PR this week, so then I can move on to the new plan of fixing the unit test warnings package by package instead of type by type.....

epugh avatar Aug 31 '22 11:08 epugh

I merged main to this. @epugh were you going to do the forbiddenapis stuff? This looks like it never got merged. The tests should be kicked off again shortly.

risdenk avatar Oct 14 '22 20:10 risdenk

:warning: 314 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift[bot] avatar Oct 14 '22 21:10 sonatype-lift[bot]

I merged main to this. @epugh were you going to do the forbiddenapis stuff? This looks like it never got merged. The tests should be kicked off again shortly.

I tried the forbiddenapis, and I think I didn't quite grok how it all worked, and ran out of energy.... If you wanted to add them to forbiddenapis, that would be great.. Otherwise, I'm happy to see this get merged!!!

Thanks for reviewing and updating these older PR's!!!

epugh avatar Oct 14 '22 21:10 epugh

I added forbiddenapis and went down the rabbit hole w/ this.

So we can't override assertThat in SolrTestCase since its static and comes from Assert which is what LuceneTestCase derives from. ForbiddenApis correctly complains that we can't just override the static method and instead knows that Assert#assertThat is still being called. So the solution in this PR isn't going to work as is.

The MatcherAssert.assertThat static import also doesn't work in each file since the base class already has the static method assertThat - so the only solution is to explicitly do MatcherAssert.assertThat.

I have a change that does that that I'll push shortly including the forbiddenapis check.

risdenk avatar Oct 15 '22 04:10 risdenk

it this PR maybe just going down the wrong approach? I'm not wedded to this one, it felt a bit werid to me as well.

epugh avatar Oct 15 '22 12:10 epugh

it this PR maybe just going down the wrong approach?

no I don't think so. As Uwe said, should really be Class#method for static and this now follows that approach. Ideally this would have been the same way as Assert.assertThat originally, but oh well. This at least makes everything consistent. It only looks ugly once.

risdenk avatar Oct 15 '22 20:10 risdenk

I'm getting a bunch of failures...

ERROR: The following test(s) have failed:
  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTruststorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTruststorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTruststorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTruststorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testHadoopCredentialProviderPrioritySysPropAndEnvVars (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testHadoopCredentialProviderPrioritySysPropAndEnvVars" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreHadoopCredentialProvider (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreHadoopCredentialProvider (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
    Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.core.TestSolrXml.testIntAsLongBad (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.core.TestSolrXml.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.core.TestSolrXml.testIntAsLongBad" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.ModuleUtilsTest.testIsValidName (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testIsValidName" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.ModuleUtilsTest.testListAvailableModules (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testListAvailableModules" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.ModuleUtilsTest.testResolveFromSyspropOrEnv (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testResolveFromSyspropOrEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.ModuleUtilsTest.testGetModuleLibPath (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testGetModuleLibPath" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.ModuleUtilsTest.testModuleExists (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testModuleExists" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.ModuleUtilsTest.testResolveModules (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testResolveModules" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromEnv (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromProperty (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwNotOverwrittenIfExists (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwNotOverwrittenIfExists" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromEnv (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromBothEnvVars (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromBothEnvVars" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromProperty (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwNotOverwrittenIfExists (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwNotOverwrittenIfExists" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreEnvVar (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromBothEnvVars (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromBothEnvVars" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromEnv (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromProperty (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromEnv (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreEnvVar (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSystemPropertyPriorityOverEnvVar (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSystemPropertyPriorityOverEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromProperty (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromKeystoreEnvVar (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8

  - org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromClientKeystoreEnvVar (:solr:core)
    Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
    Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromClientKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8


FAILURE: Build completed with 2 failures.

so need to fix these:

   >     java.lang.AssertionError: One of the overrides of setUp does not propagate the call.
   >         at __randomizedtesting.SeedInfo.seed([403B35E05244A844:4673E8D5BA170D50]:0)
   >         at org.junit.Assert.fail(Assert.java:89)

risdenk avatar Oct 17 '22 15:10 risdenk

I was on the wrong branch, and just was testing out java.lang.AssertionError: One of the overrides of setUp does not propagate the call. these as well...

ModuleUtilsTest ran fine in intelliJ directly ;-). Going to try with your new commits.

epugh avatar Oct 17 '22 18:10 epugh

Okay, this time things ran! Thanks for the fixes @risdenk

epugh avatar Oct 17 '22 20:10 epugh