SOLR-15910: Fork semver4j library to fix semver bugs.

[HoustonPutman]

https://issues.apache.org/jira/browse/SOLR-15910

[madrob]

This is kind of a pain, but I’d like to see the commits split into a clean fork and then our changes separately. Also, I don’t think we repackage the files, see org.noggit

[janhoy]

There are already 11 contributors to https://github.com/vdurmont/semver4j. Have you tried contacting them? Perhspa if we submit a PR for https://github.com/vdurmont/semver4j/issues/48 and ping a few of the devs, we can help trigger a new release? Two years old can also mean that it is mature and don't need that many updates...

[epugh]

Maybe for an adjacent library, just having a fixed version that lives as someone's personal fork in Github would also be okay? Versus bringing in this code to the Solr project itself.

Github makes it too easy to get lots of forks that all end up vaguely unmaintained, and I wish it encouraged a cluster of forks like what we see for semver to somehow come back together to a single maintained approach. Oh wait... community over code ;-)

[HoustonPutman]

Completely agree with both of you that not forking would be the best path forward. It's hard company-policy-wise for me to move forward with either of those options, but I would appreciate either of you taking it up!

[janhoy]

I'll not veto the code copy, if you clearly mark it and open, say, a blocker JIRA for 10.0 or something to replace it with something that is maintained...

[risdenk]

Looks like this was fixed and forked - https://github.com/semver4j/semver4j potentially?

[risdenk]

I updated this PR with my changes. I realized I didn't need a new PR since I was able to merge main and then use semver4j.

I need to fix a few things still solr/CHANGES.txt and maybe some other minor things, but overall this is ready to go.

[sonatype-lift[bot]]

:warning: 314 God Classes were detected by Lift in this project. Visit the Lift web console for more details.