Douglas Wilson

Results 1983 comments of Douglas Wilson

There isn't reallt a set plan right now, which is why I opened to discuss :) As it stands, this property is one issue blocking using the new code HTTP/2...

Right. But how long would people expect the 4.x and 5.x line be maintained? Would this mean actively maintaining 3 releases for a long time?

Sorry, to complete my thought: since these packages likely don't take a dependency on express and instead are subject to the version of Express the user is using, I'm not...

I've been telling people so far (even on here) that Express 4 will be supported for at least 1 year after Express 5 comes out.

We could maybe just add req.pathname in 4.16 just deprecating it in docs. Then maybe in 6 months release a 4.17 with it deprecated in code? Does that seem viable...

Right, the concern is indeed everyone, but usually the module authors are hit a bit harder when it is a change from something they don't have a direct version dependency...

So I opened the 4.16 PR, and it sounds like at least for here, we should just add a `req.pathname` property as an alias but leave `req.path` alone for now,...

Hello, I have no issue with replacing it with a better module, but it just needs to actually do the Node.js deep equal algorithm it is put there in this...

Hello, I am sorry, but I won't have time to do that for a while, as I have much higher priority objectives than this. If you are interested in this,...

The simple answer is that deepEqual is a `==` not strict deep equals, but the module you proposed, `dequal` is completely the opposite, using `===`, or strict equality. That is...