Douglas Wilson

Results 1983 comments of Douglas Wilson

Hi @artem-zakharchenko thank you for this pull request. Sorry I did not respond when it was opened. With validation type of errors like this, I like to follow the practice...

That list of methods in this module is only supposed to be the ones supported by Node.js 0.10. If you are going to make a ner major, drop 0.10 and...

And at that point, why bother with the module, just use the http module exports directly in express and stuff. This module was only made for shimming Node.js 0.10 support

This whole thing is super smelly. Just add a option that is '{stack: true}`or`{stack: false}` and thus you can perform any environment-based logic you like.

We will only accept the `true`/`false` implementation.

Pretty much `app.mountpath` is just whatever the user had mounted the app on. It's basically one of three things: 1. Just a single string. This means it was a "traditional"...

Would you be interested in setting up a Google Hangout or Skype meeting? If so, send me an email and we can set it up :) I haven't read through...

Does the contents of the README really need to be replicated into the type definitions? Any way we can add a check to CI to prevent us from letting it...

It is already case insensitive as Node.js HTTP lower cases them already. Try out the example at https://github.com/jshttp/type-is?tab=readme-ov-file#api and send upper case headers to see.

This project only works with Node.js HTTP. If you are using something else, you should be using something designed to work with whatever you are using instead.