Douglas Wilson
Douglas Wilson
> I think a better fix than this PR could be to ensure that in getStack(), obj.stack is an array of CallSite objects, and if is not (e.g. it's a...
P.S. thanks for that repo; I will use it to help dig in to a solution as well 😀
Hi @Lucas-C I'm not sure if I'm missing something here, but I tried to run your repo but I couldn't even install the modules. I am using Node.js 5.12.0, as...
> I updated this PR with the "improved" solution I suggested earlier Awesome, thank you! The million-dollar question, of course, is does the solution actually _work_ besides just not get...
> I could add a unit test that applies the same mock as core-js: do you think that would be enough? Maybe. Hard to really know until I see it,...
> Ok. I'll try to craft one soon, but this won't be high priority for me now, so feel free to replace this PR by some other solution you wrote...
Hi 👋 so great news: this can actually be easily fixed in `core-js` directly! That would fix the usage of `captureStackTrace`, `stackTraceLimit`, and other APIs that are broken with the...
I'll try to open a PR for `core-js` soon, though you are always welcome to as well if I haven't before you get a chance.
You deserve a lot of thanks as well for putting together that repo!! I don't think they intended to break this stuff; the only reason they did was because to...
Yea, you can open a PR that adds just a test if you want. As far as hardening, I mean if your changes actually work with all the features, sure....