Douglas Wilson

> proxy-addr works (with minor fix to its own test) it's actually a bug in your PR here that it relieved. the issue is that you are using a simple...

Another concern I have is why does this PR seem to be significantly slower? So this module does not have a benchmark suite, but `proxy-addr` does, so simply installing this...

> thanks for all the great feedback Absolutely! I wanted to get your the feedback quickly :) I noticed the repo was last changed in 2014, so I just make...

> and switched to using @lpinca forwarded-parse for better ANBF compatibility This part I don't understand. The entire purpose of this module is literally to do that operation, not depend...

Basically I think there is a huge misunderstanding of the current separation of concerns between the modules here. This module is meant only to be concerned with parsing/formatting of the...

A good litmus test in this organization is that if your code logically organizes into more than a single JavaScript file, that is multiple modules, not one. There are still...

Oh, I know I keep making comments but I keep thinking of new things to say :) I have not yet looked at the new changes, or even really looked...

I think `proxy-addr` should be receiving those options, and this module is the one that does the parsing for one of those "schemas": `Forwarded`.

There is no reason why it cannot do that, since those are all basically part of the "proxied address". Ideally one should at least get enough information to construct the...

Sure, it can be added, but I think an issue with that is that typically an extension can refer to several different media types, some of which could differ in...