Douglas Wilson

Results 1985 comments of Douglas Wilson

From the docs: > The request argument is expected to be a Node.js HTTP request.

Express uses Node.js HTTP. The `req.headers` object that enters into this module only contains lower case header names, even when the client sends them in capitals. This is because Node.js...

> it's still possible to invoke express with a request that technically satisfies the shape of the request object, but has upper-case headers. Then it wouldn't be the correct shape,...

Hello, and thank you for your report. Can you help by providing a reproduction of the issue you are referring to? Just paste the code in here that shows the...

Sorry for your trouble. What web browser is this happening in? As far as I can tell, the `content-disposition` header generated is following RFC 6266. Besides the web browser so...

Thank you. Unfortunately I don't have access to Safari. If you or something can see what is wrong, you are welcome to make a pull request to fix.

Hi! Yes, currently it's not possible, especially when you start to think about how we actually allow your middleware to alter `req.url`/`req.method` and we continute to route based on these...

I am taking a look now to get this released asap

It is not clear what changes are all in these finalhandler releases. I opened https://github.com/pillarjs/finalhandler/issues/63 to get some clarity and will get this fully updated when I hear back 👍...

I see you updated to 1.3.0 here but there is a 1.3.1 too. Should we update to that / what is in 1.3.1? I could not even find any commit...