Davis Chase
Davis Chase
amazing! if you have time it'd be great to add an example notebook (like the ones for chroma and pinecone). if not i can take a stab later today
thanks @GDrupal! will mention this feature on twitter, happy to tag you if there's a twitter handle you wanted me to mention!
what's the concrete suggestion here (like the code change)?
i'm for it. feel free to open a PR, otherwise I can get to it in a few hours
good catch! should we add an integration test to make sure?
> @dev2049 Integration Tests would mean we'll have to manage JIRA API keys. Not sure how to do that. :/ > Any thoughts? integration tests aren't actually run in CI...
Thanks @varun1505!
> ... > And use the `store`, and `retriever` as such with the appropriate chain one may use. this is great @eRuaro! want to open add your example to the...
> I just pushed a new updates addressing the comments. However, we were trying to add `google-cloud-storage` and `google-cloud-aiplatform` to the `pyproject.toml` but we're having dependency conflicts with `black`. Do...
> @hwchase17 I thought that was addressed with the `from_components` function. Would you comment specifically what would you need? I'm also not sure what you mean by arguments being passed...