Davis Chase

Results 192 comments of Davis Chase

@lkuligin happy to review whenever you think it's ready

seems like one of the test files is 11k lines, any chance we could use a smaller one 😅

> It's a base64 encoded image. I wanted to make sure images were removed from the note and didn't end up in the page context. > > Do we have...

@rguo123 @AndriyMulyar how does it look now?

should do this for LLM, too

apologies for my ignorance, what's difference between this and HuggingFacePipeline? is it that it uses `self.model.generate` on the underlying model to batch generate?

looking good! could we add some tests as well?

test dependencies should be ok!

could you post the full error message