langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Change in method name for creating an issue on JIRA

Open varun1505 opened this issue 2 years ago • 3 comments

The awesome JIRA tool created by @zywilliamli calls the create_issue() method to create issues, however, the actual method is issue_create().

Details in the Documentation here: https://atlassian-python-api.readthedocs.io/jira.html#manage-issues

varun1505 avatar Apr 21 '23 16:04 varun1505

good catch! should we add an integration test to make sure?

dev2049 avatar Apr 21 '23 16:04 dev2049

@dev2049 Integration Tests would mean we'll have to manage JIRA API keys. Not sure how to do that. :/ Any thoughts?

varun1505 avatar Apr 21 '23 17:04 varun1505

@dev2049 Integration Tests would mean we'll have to manage JIRA API keys. Not sure how to do that. :/ Any thoughts?

integration tests aren't actually run in CI or anything at the moment. they just make it easy to test things locally. so as long as you had jira keys in your env and ran the integration test it would work. see the other tests/integration_tests/utilities/... for examples

dev2049 avatar Apr 21 '23 17:04 dev2049

Thanks for the pointer @dev2049 . I've added the tests. Let me know if this is good to go!

varun1505 avatar Apr 21 '23 19:04 varun1505

Thanks @varun1505!

dev2049 avatar Apr 21 '23 20:04 dev2049