Davis Chase

> @dev2049 I already added the `from_components` function and I agree it is a better approach. The methods called in the constructor are validations for the `gcs_bucket_name` and that the...

> Note that the signature for `from_documents` hasn't changed other than 3 additional explicit args. guessing you have to include `**kwargs` at the end. but also note that base class...

how big is the new integration test file?

> @dev2049 which do you mean, this one: `tests/integration_tests/vectorstores/test_weaviate.py` ? this integration test also add cassettes files this one, seems like it's 200k lines `tests/integration_tests/vectorstores/cassettes/test_weaviate/TestWeaviate.test_similarity_search_without_metadata.yaml`

closing for now

will add tests and move prompt to own file but wanted to get ppl's high level thoughts first

A lot of things going on here, added all this to one branch to try to flesh out my own thinking but would split this pr up if/when we agree...

hm not sure how i feel about the specific example you provided, in which system prompt changes every call. historical messages only make sense in the context that they were...

`__call__` now uses `generate` which now has an `on_llm_end` call in it. so should be resolved! if anyone is still having issues let me know

fixed in #1912