langchain icon indicating copy to clipboard operation
langchain copied to clipboard

New Trello document loader

Open GMartin-dev opened this issue 2 years ago • 4 comments

Added New Trello loader class and documentation

Simple Loader on top of py-trello wrapper. With a board name you can pull cards and to do some field parameter tweaks on load operation. I included documentation and examples. Included unit test cases using patch and a fixture for py-trello client class.

Thanks in advance for your feedback @eyurtsev.

GMartin-dev avatar May 16 '23 06:05 GMartin-dev

Thanks @GDrupal looking mostly good -- we only need to change the location of configuration to be consistent with the loader interface

eyurtsev avatar May 16 '23 14:05 eyurtsev

@GDrupal with some sample card data, a maintain will be able to merge this change in. We'll refactor the initializer to accept the client and create a classmethod that allows instantiation from api keys

eyurtsev avatar May 17 '23 16:05 eyurtsev

@GDrupal apologies for the delay -- I'll try to merge in 1-2 days trying to set some time aside to write the tests.

However, if you're familiar with unit test library and how to use mock/patch or use the responses library to get the fixture working feel free to add the tests -- that'll be helpful :)

eyurtsev avatar May 23 '23 01:05 eyurtsev

@eyurtsev I'm familiar with unit test. I found how are you doing it in the ConfluenceLoader. I will try to have it ready in the next couple of days. Don't worry.

GMartin-dev avatar May 23 '23 05:05 GMartin-dev

thanks @GDrupal! will mention this feature on twitter, happy to tag you if there's a twitter handle you wanted me to mention!

dev2049 avatar May 30 '23 07:05 dev2049

Go for it! @musicaoriginal2 My tw handler it's messy, because i'm not only do code and I get into a lot local political discussions xD. I'm working in a project that will need a loader for Asana and utils for both Asana / Trello. I will be creating more PR's in the next couple of weeks / months. So, sadly, you guys will probably have to suffer my sloppy code a bit more.

GMartin-dev avatar May 30 '23 09:05 GMartin-dev