David Walsh

Results 51 issues of David Walsh

Relying on `this.currentMessageId` after we set the next ID could allow two rapid calls to obscure the callback number.

This PR adds a method for the Ledger to ensure the correct app is open during connection, as well as share track and share connectivity for the Hardware Connectivity UI...

This is fairly simple to reproduce: 1. Connect a Ledger account to MetaMask 2. (eth-ledger-bridge-keyring injects the github pages iframe with correct `useLedgerLive` setting) 3. Use the test dapp to...

bug

I haven't been able to determine if this problem is on the extension or keyring side, but it seems as though every error that occurs with Ledger integration makes its...

bug

* Updates lint packages * Incorporates es-lint * Applies these rules.

Infura is deprecating support for Aurora; this PR removes types for Aurora testnet and mainnet

## **Description** Provides an E2E for https://github.com/MetaMask/metamask-extension/pull/24398 When a user switches accounts during an NFT send, the asset to be sent should change to native currency [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24421?quickstart=1)...

## **Description** Isolating the request queueing E2E to just when MULTICHAIN is on. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24417?quickstart=1) ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. N/A, it's an...

team-wallet-ux
needs-assets-ux-review

## **Description** The new Multichain component removed the old UnconnectedAlert component usage; this PR removes the file and state involved. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24473?quickstart=1) ## **TODO** - [ ] Write...

team-wallet-ux
needs-assets-ux-review

## **Description** Memoizes the the value returned by `getUnapprovedConfirmations` so that a fresh object reference isn't returned from `Object.values` frequently -- at present, this new object reference is making `routes.component.js`...

team-wallet-ux
needs-assets-ux-review