David Walsh

Results 51 issues of David Walsh

## **Description** When exploring the extension performance, I spotted that the `getSelectedAccount` selector that was introduced for Multichain was returning a new object, thus the new object reference causing unnecessary...

team-wallet-ux
needs-assets-ux-review

## **Description** Uses `createDeepEqualSelector` to memoize selectors required for the AccountListMenu to cut down on rendering. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24748?quickstart=1) ## **Related issues** Fixes: N/A ## **Manual testing steps** 1....

team-wallet-ux
needs-assets-ux-review

## **Description** Adds tests for the functionality added in https://github.com/MetaMask/metamask-extension/pull/25260 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25270?quickstart=1) ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. Run jest tests ## **Screenshots/Recordings** ###...

team-wallet-ux
needs-assets-ux-review

## **Description** This PR ensures that a connection to a given network does not block the UI when switching to a dapp tab that remembers that down network, thus preventing...

team-wallet-ux

## **Description** Adds an end to end test to test that the network menu signals to dapps a network change [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25593?quickstart=1) ## **Related issues** Fixes: N/A ##...

team-wallet-ux

### Describe the bug Within the multichain UI, we remember the network the user was last connected too for a given dapp, and automatically switch to that network when the...

type-bug
regression-RC-12.0.0

## **Description** Removes the auto-switching chain logic that is used in the UI startup and in routes. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27744?quickstart=1) ## **TODO** - [ ] Add a migration to...

DO-NOT-MERGE
team-wallet-ux

## **Description** This PR makes `getCurrentChainId` return the dapp context chainId when connected to a dapp, falling back to the global chainId when not connected to a dapp. ## **...

team-wallet-ux

## **Description** This PR sets shows the network badge specific to the asset, not the globally selected chain ID. Of course for now, that chainId is shimmed to be the...

team-wallet-ux
portfolio-view

## **Description** Removes the Request Queueing feature and assumes its value [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27886?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3....

team-wallet-ux