metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: Remove UnconnectedAlert component and state

Open darkwing opened this issue 1 year ago • 1 comments

Description

The new Multichain component removed the old UnconnectedAlert component usage; this PR removes the file and state involved.

Open in GitHub Codespaces

TODO

  • [ ] Write migration to remove old state property

Related issues

Fixes: N/A

Manual testing steps

N/A, just removes old component.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar May 10 '24 03:05 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 10 '24 03:05 github-actions[bot]

Builds ready [489fdd9]
Page Load Metrics (1286 ± 589 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60168992613
domContentLoaded104619105
load50294512861227589
domInteractive94619105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 943 Bytes (0.03%)
  • ui: 76 Bytes (0.00%)
  • common: -4.64 KiB (-0.08%)

metamaskbot avatar May 21 '24 14:05 metamaskbot

Builds ready [fec857f]
Page Load Metrics (428 ± 416 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57208913417
domContentLoaded85315115
load453045428867416
domInteractive85315115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 943 Bytes (0.03%)
  • ui: 76 Bytes (0.00%)
  • common: -4.65 KiB (-0.07%)

metamaskbot avatar May 27 '24 06:05 metamaskbot

Builds ready [500ba6a]
Page Load Metrics (46 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint591047894
domContentLoaded8131011
load38644673
domInteractive8121011
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 921 Bytes (0.03%)
  • ui: 76 Bytes (0.00%)
  • common: -4.65 KiB (-0.07%)

metamaskbot avatar Jun 12 '24 23:06 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.60%. Comparing base (d8e0cd1) to head (500ba6a). Report is 758 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24473      +/-   ##
===========================================
- Coverage    65.61%   65.60%   -0.01%     
===========================================
  Files         1372     1371       -1     
  Lines        54519    54373     -146     
  Branches     14282    14270      -12     
===========================================
- Hits         35770    35669     -101     
+ Misses       18749    18704      -45     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 12 '24 23:06 codecov[bot]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions[bot] avatar Aug 12 '24 06:08 github-actions[bot]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

github-actions[bot] avatar Aug 26 '24 06:08 github-actions[bot]