metamask-extension
metamask-extension copied to clipboard
fix: Remove UnconnectedAlert component and state
Description
The new Multichain component removed the old UnconnectedAlert component usage; this PR removes the file and state involved.
TODO
- [ ] Write migration to remove old state property
Related issues
Fixes: N/A
Manual testing steps
N/A, just removes old component.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [489fdd9]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1286 ± 589 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 60 | 168 | 99 | 26 | 13 |
| domContentLoaded | 10 | 46 | 19 | 10 | 5 | ||
| load | 50 | 2945 | 1286 | 1227 | 589 | ||
| domInteractive | 9 | 46 | 19 | 10 | 5 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 943 Bytes (0.03%)
- ui: 76 Bytes (0.00%)
- common: -4.64 KiB (-0.08%)
Builds ready [fec857f]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (428 ± 416 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 57 | 208 | 91 | 34 | 17 |
| domContentLoaded | 8 | 53 | 15 | 11 | 5 | ||
| load | 45 | 3045 | 428 | 867 | 416 | ||
| domInteractive | 8 | 53 | 15 | 11 | 5 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 943 Bytes (0.03%)
- ui: 76 Bytes (0.00%)
- common: -4.65 KiB (-0.07%)
Builds ready [500ba6a]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (46 ± 3 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 59 | 104 | 78 | 9 | 4 |
| domContentLoaded | 8 | 13 | 10 | 1 | 1 | ||
| load | 38 | 64 | 46 | 7 | 3 | ||
| domInteractive | 8 | 12 | 10 | 1 | 1 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 921 Bytes (0.03%)
- ui: 76 Bytes (0.00%)
- common: -4.65 KiB (-0.07%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.60%. Comparing base (
d8e0cd1) to head (500ba6a). Report is 758 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #24473 +/- ##
===========================================
- Coverage 65.61% 65.60% -0.01%
===========================================
Files 1372 1371 -1
Lines 54519 54373 -146
Branches 14282 14270 -12
===========================================
- Hits 35770 35669 -101
+ Misses 18749 18704 -45
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.