metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

reset to native asset on account change

Open darkwing opened this issue 1 year ago • 1 comments

Description

Provides an E2E for https://github.com/MetaMask/metamask-extension/pull/24398

When a user switches accounts during an NFT send, the asset to be sent should change to native currency

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/24391

Manual testing steps

N/A, it's an E2E

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar May 08 '24 01:05 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 08 '24 01:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.35%. Comparing base (8db28c7) to head (4549bb8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24421   +/-   ##
========================================
  Coverage    67.35%   67.35%           
========================================
  Files         1285     1285           
  Lines        50113    50113           
  Branches     13004    13004           
========================================
  Hits         33753    33753           
  Misses       16360    16360           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 02:05 codecov[bot]

Builds ready [4549bb8]
Page Load Metrics (486 ± 480 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62156882210
domContentLoaded94816115
load5030234861000480
domInteractive94815115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 09 '24 02:05 metamaskbot

Thank you! :D

sahar-fehri avatar May 09 '24 09:05 sahar-fehri

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

metamaskbot avatar May 23 '24 23:05 metamaskbot