eth-ledger-bridge-keyring
eth-ledger-bridge-keyring copied to clipboard
useLedgerLive setting isn't always in sync
This is fairly simple to reproduce:
- Connect a Ledger account to MetaMask
- (eth-ledger-bridge-keyring injects the github pages iframe with correct
useLedgerLivesetting) - Use the test dapp to perform a signature
- Remove the Ledger account from MetaMask
- Add the account again
The useLedgerLive setting will be false in the IFrame, leading to the user's browser hanging (while the iframe incorrectly tries U2F.
Presently MetaMask sends the useLedgerLive setting down to the iframe when the user logs in, and when they toggle the setting. That isn't reliable enough in some cases.
The best solution here is probably going to be removing the useLedgerLive setting everywhere (extension and keyring) and simply enforcing Ledger Live for Chrome (since U2F won't be returning to Chrome) and U2F for Firefox.