Godfrey Chan

Results 103 issues of Godfrey Chan

``` /***/ "../../../../node_modules/@embroider/babel-loader-9/index.js?{\"variant\":{\"name\":\"dev\",\"runtime\":\"browser\",\"optimizeForProduction\":false},\"appBabelConfigPath\":\"/Users/godfrey/code/discourse/app/assets/javascripts/discourse/node_modules/.embroider/rewritten-app/_babel_config_.js\",\"cacheDirectory\":\"/private/var/folders/5_/psy9s2tj5h3csjy536v_cww00000gn/T/embroider/webpack-babel-loader\"}!../../../../node_modules/@embroider/webpack/src/virtual-loader.js?f=%2FUsers%2Fgodfrey%2Fcode%2Fdiscourse%2Fapp%2Fassets%2Fjavascripts%2Fnode_modules%2Fember-modifier%2F-embroider-implicit-test-modules.js&a=%2FUsers%2Fgodfrey%2Fcode%2Fdiscourse%2Fapp%2Fassets%2Fjavascripts%2Fdiscourse!": /*!********************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!*\ !*** ../../../../node_modules/@embroider/babel-loader-9/index.js?{"variant":{"name":"dev","runtime":"browser","optimizeForProduction":false},"appBabelConfigPath":"/Users/godfrey/code/discourse/app/assets/javascripts/discourse/node_modules/.embroider/rewritten-app/_babel_config_.js","cacheDirectory":"/private/var/folders/5_/psy9s2tj5h3csjy536v_cww00000gn/T/embroider/webpack-babel-loader"}!../../../../node_modules/@embroider/webpack/src/virtual-loader.js?f=%2FUsers%2Fgodfrey%2Fcode%2Fdiscourse%2Fapp%2Fassets%2Fjavascripts%2Fnode_modules%2Fember-modifier%2F-embroider-implicit-test-modules.js&a=%2FUsers%2Fgodfrey%2Fcode%2Fdiscourse%2Fapp%2Fassets%2Fjavascripts%2Fdiscourse! ***! \********************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************/ /***/ (() => { let d = window.define; /***/ }), ``` These kind of stuff gets into the development build as the...

We want to encourage users to migrate from the classic v1 "in-repo addon" to monorepo + normal v2 addon structures. There are two classes of use cases here. 1. The...

### Setup 1. `ember new --embroider --yarn zomg` (yarn optional) 2. `JOBS=0 ember s` (`JOBS=0` optional, but may get better stack traces/easier to step through the code without the workers)...

```hbs {{!-- works in standalone hbs --}} ``` ```gts {{!-- does not work in gjs, calls Function.prototype.toString instead --}} function works() { return "works"; } ``` Strict mode RFC only...

Context: https://github.com/emberjs/ember.js/pull/20673 This is not super trivial but is very important, I'd probably say we should consider it a blocker for recommending strict mode

I'm opening this issue so I have something to like to from my PR to ignore the missing peer dependency warnings on webpack in a v2 addon. As far as...

Remove the branching needed for less than supported versions (

These are slightly riskier in that you'd have to take the comment author's word for it, as the proposed code was never execrised or tested in the real world (unlike...

Related: https://github.com/embroider-build/embroider/issues/2284 TypeScript, when used with `moduleResolution = bundler` is supposed to support subpath imports. For some reason, that doesn't seem to work in Glint 1 without manually configuring `tsconfig.compilerOptions.path`....

This is regarding [this feature](https://nodejs.org/api/packages.html#subpath-imports). I couldn't find a consolidated place that documents the support status with subpath imports, so this documents my findings. * It is an emerging ecosystem...