Godfrey Chan

Results 103 issues of Godfrey Chan

good first issue

See https://api.slack.com/events-api This requires some design: this is just a placeholder epic issue.

Currently, you will have to learn the slack API response format and build the hash manually. Ideally, we should put that behind some kind of abstraction. (Similar to how Action...

Ideally, it should be quite rare to have to dig through the `params` hash to find stuff. Common things should just be methods on the base class.

good first issue

We want to change the semantics so that commands and interactions are executed synchronously (as opposed to putting it in a queue) by default. It should still be possible to...

We can refactor this [rescue](https://github.com/tildeio/slackathon/blob/master/app/jobs/slackathon/slack_command_job.rb#L21-L34) block to use Active Job's [`rescue_from` API](http://guides.rubyonrails.org/active_job_basics.html#exceptions). The main motivation for this (making the code more idiomatic is a nice bonus) is to [avoid the...

good first issue

Previously: * https://github.com/embroider-build/embroider/issues/141 * https://github.com/embroider-build/embroider/pull/243 With the recent change to put the rewritten app/packages into `node_modules/.embroider/*`, it seems like the previous fix was accidentally defeated. With addon provided templates at...

The test works locally (macOS) but doesn't appear to be working in the CI linux/windows environment. I can also reproduce it locally if I revert #1703 and opt for the...

:warning: This issue evolved into something else, https://github.com/embroider-build/embroider/issues/1589#issuecomment-1765492306 is probably the best summary of the missing feature, but I'll keep the original issue description around. It is one of the...