Godfrey Chan
Godfrey Chan
```js import { later } from '@ember/runloop'` later(...); // bad! ``` ```js import * as run from '@ember/runloop'` run.later(...); // sure, no problem :) ``` I was essentially re-implementing something...
1. Context: https://github.com/ember-tooling/ember-eslint-parser/issues/129 2. Arguably, ultimately due to: https://github.com/typescript-eslint/typescript-eslint/issues/8607 3. But @patricklx tried to solve that here in #2107 4. But that only got applied to the flat config, not...
Currently, there isn't a way to construct or recognize an "absolute" URL, i.e. `window.location.origin ( + routerService.rootURL ) + routerService.currentURL`. This will become important when we want to intercept all...
1. Using `{{outlet}}` in anything other than a route template (e.g. components) 2. Using `{{outlet}}` inside the application template of a non-routable engine (`{{mount}}`)
I think this is basically re-opening #16851 The issue is that `currentURL` does not include the `rootURL`, where as the other APIs added by the router service RFC (such as...
See https://github.com/emberjs/ember.js/pull/17874#discussion_r272809665 As part of the fix we need to decide which one fires first, since it was not specified in the RFC. My gut feeling is that the component’s...
## Which problem is this PR solving? Fixes the following eslint warnings: ``` /home/runner/work/opentelemetry-js/opentelemetry-js/api/src/diag/ComponentLogger.ts 36:25 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any 40:25 warning Unexpected any. Specify a different...
## Which problem is this PR solving? Fixes the following eslint warnings from the sdk-node package: ``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/opentelemetry-sdk-node/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 21:1 warning Using 'ExportAllDeclaration'...
Non-breaking parts from #5368 ## Which problem is this PR solving? The current interface places the generic paramter on the interface itself. This implies that the implementors of `TextMapPropagator` can...
## Which problem is this PR solving? Fix the following eslint warnings in the opentelemetry-context-async-hooks package: ``` /home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-context-async-hooks/src/AbstractAsyncHooksContextManager.ts 72:35 warning Don't use `Function` as a type @typescript-eslint/ban-types 134:60 warning Don't...