Carl Meyer

Results 203 comments of Carl Meyer
trafficstars

@geofft To me this PR now looks much bigger than necessary. This quoting style may be uncommon, but in most contexts there's nothing particularly wrong with it. I think the...

This looks good to me. There are changes to `Misc/sbom.spdx.json` but the CI check doesn't seem happy with those changes. Does it change anything if you run `make regen-sbom` again?

Merged, thanks @geofft for the contribution! (My fault on confusing the issue re merge vs rebase. It is true that typically even for resolving merge conflicts we do merge rather...

Closing as duplicate of #119666 - both are fixed by #120295.

I read the chapter. Left a few comments/questions, but I'm OK with its inclusion as-is. I feel like the `_value_` "trick" should also come for free: enum instances do have...

I agree with all the above. Assuming other typing council members feel similarly, I think that clarifies enough to allow a pull request to the spec. Side note: if we...

cc typing council members @JelleZijlstra, @hauntsaninja, @gvanrossum, @rchen152, and @erictraut -- I'd be grateful for your review and feedback here.

Also cc @superbobry, since you've expressed interest in this area

Thanks @erictraut for the excellent review! Lots of great comments here; most are clear improvements, some I think need further discussion. I really appreciate the concern for precision and clarity;...

I'm moving this back to Draft state, and removing the Typing Council decision label for now, since I think there are a couple issues to work out here before it...