Carl Meyer

Results 205 comments of Carl Meyer
trafficstars

@Feuermurmel Thanks for the proof-of-concept, I'll take a look at it when I can find a moment and see if it looks mergeable.

There is no status; patch welcome. I'm not even sure what the right fix is here yet, someone needs to look into it. Ideally there would be a way we...

I don't know; maybe @treyhunner does? If you try it and find out, submit a PR to update the docs!

Thanks for the PR! We generally maintain 100% line and branch test coverage; would you be willing to add a test to the PR that exercises this addition?

The fix is to FieldTracker, so the test would go with the rest of the FieldTracker tests. No need for a new PR, you can just add a new commit...

Some tests are run multiple times under different conditions by inheriting `TestCase` classes. The `test_post_save_previous` test is implemented in `FieldTrackerTests`, which has a `tracked_class` class attribute. Then several other testcases...

Not at all, I appreciate you sticking with it! Hmm, the PicklingError is odd. Yeah, ignore it for now and we'll see if it pops up anywhere else (e.g. on...

The change to `ModelInstanceTracker` looks fine. That class will actually go away soon, it only exists for legacy compatibility. So I guess we should have talked a bit more about...