Carl Meyer
Carl Meyer
HI @hexcubator , not sure I understand the question about separate compiler step -- what are you aiming to achieve? We don't have metrics collection as described here yet; the...
Currently the dynamic fallback warnings we have you can find by grepping `Lib/compiler/static/` for `perf_warning`. These warnings are always collected during compilation, but not surfaced anywhere currently. If you dig...
Hi! So the widening of `Union` annotations to `dynamic` is necessary for soundness at the moment because of the limitations of our runtime type checks. We special-case support for runtime...
The bad tests are addressed in 439b330b98a793eb3bece9fdbe75716763c4bac1
The explicit `c: double` should be required, we don't auto box or unbox within static code (only at function call boundaries between static and non-static code). But clearly there's a...
@DinoV did https://github.com/facebookincubator/cinder/commit/b69cb743622412d4df79ef63667ce92f027103ee also fix this issue? It looks like it might have, but it didn't explicitly add a test with literal RHS.
Yes, this is a known issue; in general our approach initially has been "opportunistic optimization," meaning we don't try to verify everything and we just fall back to dynamic if...
I think that makes sense.
We want it to be possible to use types that are not known to SP at compile time in a CheckedDict, in which case we cannot know if they are...
Yes, this is a case where we intentionally fall back to dynamic. The problem with strictly enforcing attributes is that we'd kind of like to be able to support cases...