Carl Meyer
Carl Meyer
Thanks for taking a look, @mikeshardmind! Looking forward to your further thoughts. A couple comments: > ...we can do better than not checking values with a type of Any... phrase...
Thanks @erictraut for thorough and thoughtful review! At this point I've resolved all inline comments, and I don't have further edits planned to the "concepts" doc (though I'll happily consider...
I've audited the entire type spec for consistency with this terminology and made edits as appropriate. There are some judgment calls in how to best approach this, and I welcome...
Posted for feedback at https://discuss.python.org/t/formalizing-core-definitions-in-the-typing-spec/54785
Thanks once again for all the excellent reviews! I think I've addressed all comments. Some required non-trivial additions (e.g. regarding structural vs nominal subtyping/assignability, and equivalence of gradual types) which...
I no longer use the Schwab CSV importer (I found it too painful because Schwab changes their format too frequently), so I can't personally test this. But if you get...
FWIW I think the Schwab csv importer should perhaps be abandoned/removed. I contributed it originally but I've found they change their CSV formats constantly and so I've stopped using it,...
Yes, this deserves a NEWS entry, and it should go in `Library` section, I think.
Thanks for doing this! I was hoping this would get done for 3.13 but hadn't found time to do it yet. ~I don't agree that `test_frame_locals` in `test_listcomps` should be...
Is there a reason you're leaving the failing tests as failing? I think it is easier for reviewers to evaluate the compatibility impact on tests by seeing the required changes...