Carl Meyer comments

Results 212 comments of


                                            Carl Meyer

trafficstars

unittest.mock.create_autospec() can crash when accessing properties from objects

I don't think property execution is by design. Historically, properties were not executed by creation of a specced Mock. The execution of properties was introduced relatively recently (3.8) along with...

gh-87634: deprecate cached_property locking, add lock kwarg

@eendebakpt Interesting idea! I think the best place to keep an unfragmented discussion of options is over on the issue #87634 rather than on this closed PR, so I'll reply...

`test_generator_trace` fails on Python 3.11

Fixed by #279 . (Root cause here was that in Python 3.11 the `f_lasti` of a frame when resuming a generator is no longer the `YIELD` opcode, it's now the...

Test failures on Python 3.11 due to upstream changes in handling `Tuple[()]`

Fixed by #279

Chrome w/ Chromedriver 106 - High failure rates of: "InvalidArgumentException: Message: invalid argument: No target with given id found" and "WebDriverException: Message: disconnected: received Inspector.detached event"

The problem still exists in chromedriver/chrome v107. The linked fix branch still works if the version constraint is removed or extended to cover v107 in addition to 106.

gh-91053: Add an optional callback that is invoked whenever a function is modified

Discussed offline with @markshannon and reached these conclusions (Mark please let me know if any of this doesn't match your understanding): 1. In the long term it might be better...

Typing spec: More consistent, formalized language

I think https://github.com/python/typing/pull/1743, if merged, covers the "glossary and introductory text" as well as an effort to make the rest of the spec align with those terms. There are some...

Typing spec: More consistent, formalized language

I haven't thought of any others yet (or if I did, I forgot to make note of them.) I think it'll be clearer to have specific issues for each further...

`import a.b` - should `a` be considered imported?

IMO there are some side effects of import that should not be relied on and that a type checker should not model. For instance, the fact that `import a.b` being...

Add an enabled-by-default rule about imports from an src package

This rule would just make it an error to have a top-level package named `src` in your project, with the reasoning that the name `src` is most commonly used for...