Bartlomiej Plotka

We can't use it until this or something similar is merged: https://github.com/minio/minio-go/pull/1673 I proposed fix to upsteam, let's see. I updated our fork for now: https://github.com/thanos-io/thanos/pull/5474

This is epic report - @jessicalins thank you! Perfect pattern for providing all possible info 🤗

Yup, too late ): Good point about go routines - we forgot. Let's capture it next time it happens. We lost all pprof things 🤗

Nice! From Thanos side, our downsampling proven to be precise, and gave huge boost for queries for longer time retention (year). However there few things we wanted to improve and...

Hi, thanks for the report :wave: Yea, I think this is essentially some edge case for our penalty algorithm. The code is here: https://github.com/improbable-eng/thanos/blob/master/pkg/query/iter.go#L416 The problem is that this case...

Yes! we care about samples only as well so you can mask series if you want for privacy reasons! :+1: (:

Looks like this is last standing deduplication characteristic we could improve. I would not call it bug necessarily, it is just not responsive enough by design. I plan to adjust...

We have been discussing this in the past. The endpoint address was assumed not stable enough (e.g. same store API replica on restart would have different IP). On top of...

Ok, so my proposal would be to: * Always trim external labels to e.g. 1000 chars. * Add a `[]string` flag to querier like `querier.conn-metric.labels` that allows specifying NO, or...

From community discussion: * It makes sense, let's do this * Ideally disabled by default to not break compatibiltiy * Provide best practices - what works