Bartlomiej Plotka

Results 704 comments of Bartlomiej Plotka

Ok, migration goal moved to another ticket: https://github.com/improbable-eng/thanos/issues/348 This tickets stays as ability to run Prometheus with local compaction + sidecar for long period and use it as it is....

Yea, local only compaction would solve some issues, nice idea, but unfortunately: > Is global compaction still needed? The sidecars could downsample the data before uploading, I don't know about...

BTW: > Performance issue prometheus/prometheus#3601 relates to the query returning gigabytes of data, is there any reason to think thanos store would handle that better? 1. Definitely not worse than...

Totally missed this, sorry. > While one solution is to have multiple buckets to distribute the compaction load that way, would it be possible to add a flag to the...

It would be amazing to get back to this. @daixiang0 no as it's Prometheus compaction, not Compactor really.

I think the solution is vertical compaction which is quite stable as long as data is 1:1

Yup, but we can treat that separately. I think it's necessary work. The only question I have: * Should we do it in endpointset? * Or rather in gRPC natively...

Also we need this for Querier

I am not fully bought on this honestly, need to look deeper 🙈