thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Use original Minio upstream for Minio client

Open B0go opened this issue 3 years ago • 4 comments

Issue https://github.com/thanos-io/thanos/issues/5130 reports two problems, the incompatibility between the local development Minio version and Apple silicon and the need to go back to using Minio's upstream instead of a fork. We opted to keep that issue focused on the local development and create a new one to return to the upstream because this second part is way more complicated.

The context why Thanos is now using a fork of Minio's client can be found here: https://github.com/thanos-io/thanos/issues/3967

@wiardvanrij also provided this example of problems related to using the fork: https://github.com/thanos-io/thanos/issues/5101

To return using the upstream, we need to figure out how to solve the race condition problem stated in the original task (prior to migrating to the fork) so we can help Minio team and move back to the original repository

B0go avatar May 29 '22 20:05 B0go

Are you planning to help here with PR? 🤗 otherwise I might have time to fix it. We can get back to upstream with config option mentioned https://github.com/minio/mc/issues/3376#issuecomment-806013131 or we can propose fix to upstream

bwplotka avatar May 30 '22 16:05 bwplotka

I do plan on helping with other Thanos issues, but I believe you have more context to address this one @bwplotka :)

B0go avatar May 30 '22 17:05 B0go

We can't use it until this or something similar is merged: https://github.com/minio/minio-go/pull/1673 I proposed fix to upsteam, let's see.

I updated our fork for now: https://github.com/thanos-io/thanos/pull/5474

bwplotka avatar Jul 05 '22 15:07 bwplotka

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Sep 21 '22 02:09 stale[bot]

Hey, Any update on that? IMDSv2 is a security requirement, hence, we can not leave those hanging fruits

oded-dd avatar Nov 04 '22 09:11 oded-dd

I believe this can be closed, as it was resolved as part of https://github.com/thanos-io/thanos/issues/5101 . We are successfully using IMDSv2 with Thanos in our environment.

markmsmith avatar Mar 21 '23 18:03 markmsmith