thanos
thanos copied to clipboard
Allow using shuffle sharding
Is your proposal related to a problem?
To limit blast radius of a multi-tenant Thanos receive setup.
Describe the solution you'd like
Shuffle Sharing would be useful to allow creating sub-rings within a hashring of receive nodes.
Describe alternatives you've considered
Leaving as is, which causes distribution of series to be across the entire hashring, instead of a sub-set of the hashring, causing the blast radius to be the entire cluster, instead of a sub-set. Or not use Thanos.
@thanos-io/thanos-maintainers
I actually contributed to https://github.com/clickyotomy/go-shuffle-shard so that we don't have to reinvent all of this, and just wire it up with our existing hashring infrastructure.
Sweet 🤗
Can I take a stab at this issue? Seems quite interesting to me 😅
I would like us to first get https://github.com/thanos-io/thanos/pull/3580 over the finish line, otherwise we'll just keep piling on conflicts.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Still valid.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Closing for now as promised, let us know if you need this to be reopened! 🤗
Hi @GiedriusS ! Thanks to stale bot, I was interested in solving this issue, can I take a look 😅
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Closing for now as promised, let us know if you need this to be reopened! 🤗
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.