thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Allow using shuffle sharding

Open brancz opened this issue 4 years ago • 14 comments

Is your proposal related to a problem?

To limit blast radius of a multi-tenant Thanos receive setup.

Describe the solution you'd like

Shuffle Sharing would be useful to allow creating sub-rings within a hashring of receive nodes.

Describe alternatives you've considered

Leaving as is, which causes distribution of series to be across the entire hashring, instead of a sub-set of the hashring, causing the blast radius to be the entire cluster, instead of a sub-set. Or not use Thanos.

@thanos-io/thanos-maintainers

brancz avatar Feb 22 '21 13:02 brancz

I actually contributed to https://github.com/clickyotomy/go-shuffle-shard so that we don't have to reinvent all of this, and just wire it up with our existing hashring infrastructure.

brancz avatar Feb 22 '21 14:02 brancz

Sweet 🤗

bwplotka avatar Feb 22 '21 17:02 bwplotka

Can I take a stab at this issue? Seems quite interesting to me 😅

yashrsharma44 avatar Feb 26 '21 07:02 yashrsharma44

I would like us to first get https://github.com/thanos-io/thanos/pull/3580 over the finish line, otherwise we'll just keep piling on conflicts.

brancz avatar Feb 26 '21 07:02 brancz

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jun 02 '21 17:06 stale[bot]

Still valid.

kakkoyun avatar Jun 03 '21 09:06 kakkoyun

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Aug 02 '21 18:08 stale[bot]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Oct 11 '21 06:10 stale[bot]

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] avatar Oct 30 '21 17:10 stale[bot]

Hi @GiedriusS ! Thanks to stale bot, I was interested in solving this issue, can I take a look 😅

yashrsharma44 avatar Oct 31 '21 05:10 yashrsharma44

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jan 09 '22 02:01 stale[bot]

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] avatar Mar 02 '22 22:03 stale[bot]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar May 02 '22 09:05 stale[bot]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Jul 31 '22 04:07 stale[bot]