Bart Koelman

/azp run cleanup-code

The file `git.properties` occurs 4 times in the source tree, likely originating from https://github.com/git-commit-id/git-commit-id-maven-plugin. There's also variants, such as `empty.git.properties` and `garbage.git.properties`. Can these be removed and added to `/.gitignore`?...

The file `AspNetCoreHostingObserverTest.cs` was moved into Metrics subfolder, but the class is marked as: ```c# [Obsolete("To be removed in the next major version.")] ``` Can it be removed instead?

> > The file `git.properties` occurs 4 times in the source tree, likely originating from https://github.com/git-commit-id/git-commit-id-maven-plugin. There's also variants, such as `empty.git.properties` and `garbage.git.properties`. > > Can these be removed...

@TimHess Perhaps the next article helps in getting users migrated to the new packages: https://learn.microsoft.com/en-us/nuget/nuget-org/deprecate-packages#client-experience-for-deprecated-packages: > Visual Studio warns about a deprecated package's usage on the Installed tab. It will...

Thanks for providing the stats. I consider them a rough indication, let's not forget that these rules propagate. For example, when adding an overload that takes an Uri parameter in...

After adding: ```xml ``` to `sharedtest.props` and removing unused usings, FluentAssertions.Analyzers no longer works. It is unable to handle global namespace imports. My changes up to this point are in...

Thanks! Sounds like a good reason to postpone addressing this, until we have narrowed down the public API surface. The rule ignores non externally visible methods.

Considerations - Review namespaces - Consider the use of [pubternal](https://www.reddit.com/r/dotnet/comments/jwzgl9/word_of_the_day_pubternal/) - Adjust namespaces based on directory (or adapt project structure to match namespaces) - ~Don't put extensions methods in System...

I don't think it should ever look at namespace imports. For example, it won't work on the next file: ```c# // No using [Xunit.Fact] public void SomeTest() { } ```...