Bart Koelman
Bart Koelman
> I was originally planning on making FilePath relative to the application's working directory. Looking at how existing logging frameworks resolve a relative path, we found the following (not entirely...
This is still wrong. Try debugging through it:  The `changeCalled` variable is set to `true` _before_ the files get written.
Should probably dispose `X509Certificate2` instances in tests.
Wouldn't it be easier to test via `OptionsMonitor`, such as in the test [ChangeConfiguration_AppliesChanges](https://github.com/SteeltoeOSS/Steeltoe/blob/f7cee9f8b3cc146c644ce9a51dc80f84f467208a/src/Discovery/test/Eureka.Test/EurekaApplicationInfoManagerTest.cs#L112), combined with `MemoryFileProvider`, such as in the test [Reloads_options_on_change](https://github.com/SteeltoeOSS/Steeltoe/blob/f7cee9f8b3cc146c644ce9a51dc80f84f467208a/src/Configuration/test/Placeholder.Test/PlaceholderConfigurationTest.cs#L332)? Then the sleeps can be removed.
> I do like the idea of using `MemoryFileProvider`, but the problem is that `FilePathInOptionsChangeTokenSource` depends on the private class `FileSystemChangeWatcher` which only works with `PhysicalFilesWatcher`. I see an option...
Additionally, it would be nice to order the components in the response in descending order of status, so that failures appear at the top of the list.
For further reference: - https://docs.spring.io/spring-boot/reference/features/logging.html#features.logging.log-groups - https://www.baeldung.com/spring-boot-log-groups - https://docs.spring.io/spring-boot/reference/actuator/loggers.html Sample output: ```json { "levels": [ "OFF", "FATAL", "ERROR", "WARN", "INFO", "DEBUG", "TRACE" ], "loggers": {...}, "groups": { "web": { "members":...
Pending alignments: - ~Connector and~ Discovery samples don't use the `Steeltoe.Samples` namespace prefix, app/service name in `manifest.yml` doesn't follow naming guidelines. - Security samples don't use the project name suffixes,...
This is about isolation, not parallelism. Samples tend to create a database. If the schema differs per branch, it won't succeed because the existing schema is incompatible. Using different spaces...
Aspire [goes a step further](https://github.com/dotnet/aspire/issues/6890) by mounting the ASP.NET dev cert in the docker container.