Bart Koelman

Results 122 comments of Bart Koelman

In my case, the namespace imports are in a .props file, which is conditionally imported from another props file, which is imported from the .csproj.

And to complicate it some more, I've once had to use: ```xml enable ``` to avoid numerous namespace clashes with my own `Task` class.

Isn't the goal to promote the use of FluentAssertions over Xunit/MSTest assertions? The `using ... as` construct is a C# notation unrelated to that, so it should not matter. There...

Thinking about this some more... walking up the syntax tree won't be very reliable either. The next example wouldn't work: ```c# [Fact] public void TestRequestAB() { var response = ExecuteGetRequest("/a?b=1");...

Another source for inspiration: The Sonar analyzer for [S2699: Tests should include assertions](https://rules.sonarsource.com/csharp/RSPEC-2699), which supports xUnit and FluentAssertions. These analyzers are widely-used and optimized for high performance in large codebases....

The same issue applies to: - S4456: Parameter validation in yielding methods should be wrapped - S4457: Parameter validation in "async"/"await" methods should be wrapped I couldn't find a product...

Thanks, that estimation is helpful. I've created #5744 for S4456/S4457.

Hi @thompson-tomo, I closed this issue as part of the Connectors work I did on Steeltoe v4, which hasn't yet been released. A PR to fix this in v3 would...

The plan is to replace `DiscoveryClient.OnApplicationsChange` which exposes all mutable internals and has no test coverage, with an event that provides access to `IList`. @macsux Thoughts?

Related to: https://github.com/SonarSource/sonar-dotnet/issues/7633