Bart Koelman

Results 122 comments of Bart Koelman

We shouldn't have long-lived `HttpClient` instances in the first place. They won't be able to reflect configuration changes, such as setting a proxy, changing timeouts (throws after the first request...

The sample at https://github.com/SteeltoeOSS/Samples/blob/latest/Connectors/src/Redis/Program.cs shows how the connection string can be overruled in Steeltoe v4.x from code. Specifically, the line: ```c# redisOptions.ClientName = "redis-connector"; ``` can be supplemented with: ```c#...

@TimHess What's needed to get this resolved? We now have a config-server image that supports discovery, but the cibuild doesn't start a Eureka instance. I wonder if it should, as...

@eerhardt We've completed this work in #1317. Our chosen strategy is detailed below. 1. We've removed all redundant host builder extension methods. - No host builder extension methods are provided,...

Closing this PR in favor of #1327.

@TimHess Since the related PR has been closed unmerged, does this issue need to remain open?

Many violations (see the list at https://github.com/SteeltoeOSS/Steeltoe/pull/1053#issuecomment-1332214236) originate from Connectors, which allow a comma-separated URI format that's incompatible with `System.Uri`. It's unclear to me whether we need to preserve support...

Hi @yassinebennani, thanks for reporting this. Yes, you're right. The Eureka client needs an `HttpClient` to access the Eureka server, which is causing a circular dependency. As a result, the...

Closing, as the additional work has been completed. An updated sample is available at https://github.com/SteeltoeOSS/Samples/tree/latest/Discovery/src/FortuneTeller. Updated documentation is at https://github.com/SteeltoeOSS/Documentation/tree/v4/api/v4/discovery, specifically [here](https://github.com/SteeltoeOSS/Documentation/blob/v4/api/v4/discovery/discovering-services.md#global-service-discovery).

We don't intend to strong-name-and-sign packages in Steeltoe v4, based on [this](https://github.com/SteeltoeOSS/Steeltoe/issues/18#issuecomment-1162933954). Aside from the recommendations against it, signing is viral. A signed package requires that all of its dependencies...